Improve connect cluster vault error handling

[ThomasCAI-mlv]

For the connect cluster vault API, I simplified the validateConnectClusterVault method check:

• If the provided connect cluster is not found (the connect cluster does not exist or the namespace does not have the OWNER or WRITE ACL on this connect cluster), throw an "not found" error
• If the provided connect cluster is found but is missing AES config fields, throw an "no config" error. I updated the error message to be more explicit, because previously, it was confusing to display the list of other usable vault connect clusters, since the user explicitly gave the connect cluster he wants to use to vault his secrets. In any case, they can use the LIST vaults API to list the available vaults connect clusters.

I also removed the "allowed namespace" check because it was weird to provide information of another namespaces to a given namespace.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[loicgreffier]

@ThomasCAI-mlv Good improvements 👍

• I updated the error message AES key and salt are required to use connect-cluster vault to not have a command-line on server side
• I had some doubts about removing:

  ns4kafka/src/main/java/com/michelin/ns4kafka/service/ConnectClusterService.java

  Line 318 in 95f399b

  errors.add(FormatErrorUtils.invalidConnectClusterMustBeOneOf(connectCluster, allowedConnectClusters));

  For connectors, if there is an error on the connectCluster, the list is suggested:

  ns4kafka/src/main/java/com/michelin/ns4kafka/service/ConnectorService.java

  Line 132 in 95f399b

  return Mono.just(List.of(invalidConnectorConnectCluster(connector.getSpec().getConnectCluster(),

  . But I guess only saying that the resource is not found is acceptable