Update German translation #2282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mh, I feel something is wrong since some of the deleted translations still seems to be used here. |
|
|
|
@Amr-Ibra |
sergio-costas
requested changes
Jan 24, 2025
|
I was able to fix it by using msgmerge, but that will require a change in the Makefile... I'll see what I can do. |
|
Oh... the makefile doesn't use intltool-update, but msgmerge... forget what I said. |
Amr-Ibra
force-pushed
the
german-translation
branch
from
563d7cd to
1822b3a
Compare
I did that, and I think it fixed the problem. There aren't as many deleted translations as there were before I pushed my last change. I think it's safe to merge this PR now. |
sergio-costas
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Poedit can delete many “unused translations”. The question is: is Poedit right? Are there really so many unused translations to delete? Have the original strings really got removed from the source code?
I haven't deleted any “unused translations” yet. But I can update this PR to delete them after confirmation from the developers that the original strings got removed from the source code.