Fix #10 - add options and catch the boolean error (#11)

* Fix #10 - add options and catch the boolean error * Apply suggestions from code review Co-authored-by: Michal Vanko <[email protected]> Co-authored-by: Michal Vanko <[email protected]>
michalvankodev · Jan 13, 2023 · 73648fe · 73648fe
1 parent eb74ba7
commit 73648fe
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ jobs:
     name: Copy labels from linked issues
     steps:
       - name: copy-labels
-        uses: michalvankodev/[email protected].0
+        uses: michalvankodev/[email protected].1
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 ```
@@ -46,7 +46,7 @@ These keywords will not override github specified keywords.
 ```yml
 steps:
   - name: copy-labels
-    uses: michalvankodev/[email protected].0
+    uses: michalvankodev/[email protected].1
     with:
       repo-token: ${{ secrets.GITHUB_TOKEN }}
       custom-keywords: |
@@ -61,7 +61,7 @@ You can provide from-title = true to parse the issue numbers from title
 ```yml
 steps:
   - name: copy-labels
-    uses: michalvankodev/[email protected].0
+    uses: michalvankodev/[email protected].1
     with:
       repo-token: ${{ secrets.GITHUB_TOKEN }}
       from-title: true

diff --git a/action.yml b/action.yml
@@ -8,6 +8,9 @@ inputs:
     description: 'The GITHUB_TOKEN secret'
   custom-keywords:
     description: 'List of custom keywords which should be included in the parser'
+  from-title:
+    description: 'To parse the issue numbers from title, a boolean'
+    required: false
 runs:
   using: 'node12'
   main: 'dist/index.js'
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/index.ts b/src/index.ts
@@ -14,10 +14,18 @@ function getInputAsArray(name: string, options?: core.InputOptions): string[] {
     .filter((x) => x !== '')
 }
 
+function getBooleanInput(name: string, options?: core.InputOptions, defaultValue: boolean = false): boolean {
+  try {
+    return core.getBooleanInput(name, options)
+  } catch (ex) {
+    return defaultValue
+  }
+}
+
 async function run() {
   const token = core.getInput('repo-token', { required: true })
   const customKeywords = getInputAsArray('custom-keywords', { required: false })
-  const fromTitle = core.getBooleanInput('from-title', { required: false })
+  const fromTitle = getBooleanInput('from-title', { required: false })
 
   const issueNumber = getIssueNumber(
     core.getInput('issue-number', { required: false })
@@ -66,7 +74,7 @@ async function run() {
     }, [])
   )
 
-  await client.issues.addLabels({
+  labels.length > 0 && await client.issues.addLabels({
     owner: github.context.repo.owner,
     repo: github.context.repo.repo,
     issue_number: issueNumber,