Fix default 'copies' value for papplJobCreateWithFile.

michaelrsweet · Oct 30, 2023 · 3d962e7 · 3d962e7
1 parent 49f9a0c
commit 3d962e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -17,3 +17,4 @@ Changes in v2.0b1
 - Fixed potential deadlock issue (Issue #297)
 - Fixed loading of previous state (Issue #298)
 - Fixed "printer-id" value for new printers (Issue #301)
+- Fixed default "copies" value with `papplJobCreateWithFile`.
diff --git a/pappl/job.c b/pappl/job.c
@@ -101,6 +101,7 @@ _papplJobCreate(
   job->state   = IPP_JSTATE_HELD;
   job->system  = printer->system;
   job->created = time(NULL);
+  job->copies  = 1;
 
   if (attrs)
   {
@@ -118,8 +119,6 @@ _papplJobCreate(
 
     if ((attr = ippFindAttribute(job->attrs, "copies", IPP_TAG_INTEGER)) != NULL)
       job->copies = ippGetInteger(attr, 0);
-    else
-      job->copies = 1;
 
     hold_until      = ippGetString(ippFindAttribute(attrs, "job-hold-until", IPP_TAG_KEYWORD), 0, NULL);
     hold_until_time = ippDateToTime(ippGetDate(ippFindAttribute(attrs, "job-hold-until-time", IPP_TAG_DATE), 0));