Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream feature locations #11

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

michaelkirk
Copy link
Owner

@michaelkirk michaelkirk commented Jul 18, 2024

This allows the client to start fetching FeatureData a little bit sooner.

TBH the measurable impact is pretty minimal in the browser, but I do see a little parallelism.

image

Before, on the left, you can see we don't fetch any Feature data until all the index traversal is complete.

On the right, you can see we start fetching Feature data a little earlier, before completing index traversal. Particularly interesting are those last two index traversal requests, which I think indicate dead end nodes - that is, nodes whose bounding boxes intersects ours, but who don't actually have any nodes in our bbox.

@michaelkirk michaelkirk merged commit cb2db7c into main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant