Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Galois field array code and tests #173

Merged
merged 12 commits into from
Aug 24, 2021
Merged

Conversation

mhostetter
Copy link
Owner

No description provided.

@mhostetter mhostetter added the testing Relates to unit testing or test coverage label Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #173 (722c4dc) into master (1a459a7) will increase coverage by 0.80%.
The diff coverage is 87.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   91.65%   92.46%   +0.80%     
==========================================
  Files          37       37              
  Lines        4304     4235      -69     
==========================================
- Hits         3945     3916      -29     
+ Misses        359      319      -40     
Impacted Files Coverage Δ
galois/_fields/_array.py 89.15% <ø> (+0.66%) ⬆️
galois/_fields/_class.py 90.00% <ø> (+1.44%) ⬆️
galois/_lfsr.py 93.16% <66.66%> (ø)
galois/_fields/_functions.py 82.23% <74.41%> (-8.59%) ⬇️
galois/_fields/_lookup.py 91.13% <84.09%> (+6.61%) ⬆️
galois/_fields/_gfp.py 90.81% <89.23%> (-7.06%) ⬇️
galois/_fields/_gf2m.py 91.34% <90.00%> (-5.66%) ⬇️
galois/_fields/_gfpm.py 94.94% <94.11%> (-3.04%) ⬇️
galois/_codes/_bch.py 97.98% <100.00%> (+0.48%) ⬆️
galois/_codes/_reed_solomon.py 98.69% <100.00%> (+0.64%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a459a7...722c4dc. Read the comment docs.

@mhostetter mhostetter force-pushed the fields-code-coverage branch 2 times, most recently from b359f07 to 589a2ed Compare August 18, 2021 14:00
@mhostetter mhostetter force-pushed the fields-code-coverage branch from 589a2ed to 771dc92 Compare August 18, 2021 14:00
@mhostetter mhostetter changed the title Improve unit testing of Galois field arrays Clean-up Galois field array code and tests Aug 20, 2021
@mhostetter mhostetter force-pushed the fields-code-coverage branch 5 times, most recently from ea24794 to fa00388 Compare August 21, 2021 21:02
@mhostetter mhostetter force-pushed the fields-code-coverage branch 6 times, most recently from 3d6b8b7 to a48290f Compare August 24, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to unit testing or test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numba 0.54 NumbaIRAssumptionWarning
1 participant