-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make agreement name customizable #674
Conversation
@DeepaPrasanna is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/assign |
Assigned to @TechWitkunal! Please open a draft PR linking this issue within 48h |
/assign |
Assigned to @TechWitkunal! Please open a draft PR linking this issue within 48h |
Hey @TechWitkunal you have mentioned /assign on a pr. This is not an issue |
hey there.. how to sign CLA ? |
when the bot shows , you have to write that statement |
Hello @mfts , it seems someone assigned my PR. I have already worked on this and was waiting for your reviews. |
@DeepaPrasanna you are definitely first. I will close the original issue and award you here directly. I do have one change request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please change the label on the "form" where we enter the name and add the NDA to "Display Name"
@TechWitkunal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
1 similar comment
@TechWitkunal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix :)
Awarding DeepaPrasanna: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna |
fixes #651
I have utilised the name field of the agreement to show instead of NDA or privacy policy which were hardcoded. I have tested locally when the linkType was DATAROOM.
but for linkType as DOCUMENT, I am unable to do so as I am encountering an error on viewing an uploaded document
this error is not on production, I am still trying to figure what might have caused this.