Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make agreement name customizable #674

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

DeepaPrasanna
Copy link
Contributor

fixes #651

I have utilised the name field of the agreement to show instead of NDA or privacy policy which were hardcoded. I have tested locally when the linkType was DATAROOM.
image

but for linkType as DOCUMENT, I am unable to do so as I am encountering an error on viewing an uploaded document
image

this error is not on production, I am still trying to figure what might have caused this.

Copy link

vercel bot commented Oct 7, 2024

@DeepaPrasanna is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 7, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@DeepaPrasanna
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 4:48am

@TechWitkunal
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @TechWitkunal! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@TechWitkunal TechWitkunal removed their assignment Oct 10, 2024
@TechWitkunal
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @TechWitkunal! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@DeepaPrasanna
Copy link
Contributor Author

Hey @TechWitkunal you have mentioned /assign on a pr. This is not an issue

@Meetpidev
Copy link

I have read the CLA Document and I hereby sign the CLA

hey there.. how to sign CLA ?

@DeepaPrasanna
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

hey there.. how to sign CLA ?

when the bot shows , you have to write that statement

@DeepaPrasanna
Copy link
Contributor Author

Hello @mfts , it seems someone assigned my PR. I have already worked on this and was waiting for your reviews.

@mfts
Copy link
Owner

mfts commented Oct 11, 2024

@DeepaPrasanna you are definitely first. I will close the original issue and award you here directly.

I do have one change request:

  • could you please change the label on the "form" where we enter the name and add the NDA to "Display Name"

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please change the label on the "form" where we enter the name and add the NDA to "Display Name"

@DeepaPrasanna
Copy link
Contributor Author

How is this?
Before:
Screenshot 2024-10-11 202556
After:
Screenshot 2024-10-11 202809

Would you like me to change the htmlfor attribute value from name to display-name? I kept "name" for now.

Copy link

oss-gg bot commented Oct 12, 2024

@TechWitkunal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

1 similar comment
Copy link

oss-gg bot commented Oct 12, 2024

@TechWitkunal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix :)

@mfts mfts merged commit c5bc9f8 into mfts:main Oct 12, 2024
3 checks passed
Copy link

oss-gg bot commented Oct 12, 2024

Awarding DeepaPrasanna: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
@DeepaPrasanna DeepaPrasanna deleted the feat/custom-agreement-name branch October 12, 2024 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Make an agreement's display name customizable
4 participants