-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the custom not found page #655
Conversation
@Pratham271 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
@Pratham271 thanks for the contribution. would you mind signing the CLA as indicated above, please :) |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app/not-found.tsx
only works in the app directory. However, almost all pages are in the pages/
directory.
The router cannot find the not-found page from app router and instead is looking for the 404 page in pages directory
@mfts but locally when I added 404 page it was not working properly. Can you explain me again please the changes that you suggested |
/assign |
Assigned to @Aditya-PS-05! Please open a draft PR linking this issue within 48h |
@mfts I have made the requested changes and now it is working fine for pages in the pages directory |
@mfts |
@Pratham271 it's still causing an error. Can you also share a screenshot of what this improved error page looks like? |
@mfts by mistake I removed a closing div just before the p tag let me make it right |
@mfts |
@Pratham271 the search is currently not working. Also the buttons don't make sense, especially since an external visitor will see it and they may not have a papermark account so home, documents and settings are useless to them. I will award you for your effort but close this PR for now. /award 50 |
Awarding Pratham271: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Pratham271 |
resolves #637