Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the custom not found page #655

Closed
wants to merge 4 commits into from

Conversation

Pratham271
Copy link

resolves #637

@Pratham271 Pratham271 requested a review from mfts as a code owner October 4, 2024 08:48
Copy link

vercel bot commented Oct 4, 2024

@Pratham271 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 4, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mfts
Copy link
Owner

mfts commented Oct 4, 2024

@Pratham271 thanks for the contribution. would you mind signing the CLA as indicated above, please :)

@Pratham271
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app/not-found.tsx only works in the app directory. However, almost all pages are in the pages/ directory.

The router cannot find the not-found page from app router and instead is looking for the 404 page in pages directory

@Pratham271
Copy link
Author

@mfts but locally when I added 404 page it was not working properly. Can you explain me again please the changes that you suggested

@Aditya-PS-05
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @Aditya-PS-05! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Pratham271
Copy link
Author

@mfts I have made the requested changes and now it is working fine for pages in the pages directory

@Aditya-PS-05
Copy link

@mfts
Please review my pr.

@mfts
Copy link
Owner

mfts commented Oct 13, 2024

@Pratham271 it's still causing an error.

CleanShot 2024-10-13 at 14 14 55@2x

Can you also share a screenshot of what this improved error page looks like?

@Pratham271
Copy link
Author

@mfts by mistake I removed a closing div just before the p tag let me make it right

@Aditya-PS-05
Copy link

@mfts
Please merge this if everything is good.

@mfts
Copy link
Owner

mfts commented Oct 22, 2024

@Pratham271 the search is currently not working. Also the buttons don't make sense, especially since an external visitor will see it and they may not have a papermark account so home, documents and settings are useless to them.

I will award you for your effort but close this PR for now.

/award 50

@mfts mfts closed this Oct 22, 2024
Copy link

oss-gg bot commented Oct 22, 2024

Awarding Pratham271: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Pratham271

@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] To have a better not found page.
3 participants