Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing link in branding #1312

Merged
merged 5 commits into from
Oct 29, 2024
Merged

fix: added missing link in branding #1312

merged 5 commits into from
Oct 29, 2024
+43 −5

Conversation

JeevaRamanathan
Copy link
Contributor

Fixes #1311
Added the missing link for How to customize data room branding? in branding screen

@vercel Vercel
Copy link

vercel bot commented Oct 27, 2024

@JeevaRamanathan is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@mfts
Copy link
Owner

mfts commented Oct 28, 2024

Hi @JeevaRamanathan this is actually describing the dataroom branding. not the document branding. You can add this to the dataroom branding page. /dataroom/[id]/settings

@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 28, 2024 •
edited
Loading

Oh yeah my bad.
So for this with a title "How to customize document branding?" -> https://www.papermark.io/help/category/branding will be adding in settings/branding

And the actual one under /dataroom/[id]/settings

@JeevaRamanathan
fix: links
6377f2c 
Signed-off-by: JeevaRamanathan <[email protected]>
@JeevaRamanathan
Copy link
Contributor Author

@mfts could you please have a look now and let know on any changes, Thanks!

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 9:53am

@mfts mfts merged commit ab1701a into mfts:main Oct 29, 2024
3 checks passed
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 29, 2024

Awarding JeevaRamanathan: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/JeevaRamanathan

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfts mfts mfts approved these changes

Assignees
No one assigned
Labels
hacktoberfest 🕹️ 150 points 🕹️ oss.gg player submission
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🕹️]Link not available for How to customize in branding
2 participants
@JeevaRamanathan @mfts