Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch underlying matrix library from gomatrix to mautrix-go #37

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

metskem
Copy link
Contributor

@metskem metskem commented Aug 30, 2024

Since the gomatrix library is no longer supported, I think we should switch to mautrix-go.

include a few dependency bumps and switch to golang 1.23
@sebhoss
Copy link
Member

sebhoss commented Aug 30, 2024

Thanks a lot!

AFAIK the room joining part was added so that the initial setup in a complete new rooms works fine, e.g. in our case we have to invite the bot account to a room and the bot has to somehow accept that invitation before being able to send messages. Does this work in the new library without doing an explicit join?

@metskem
Copy link
Contributor Author

metskem commented Aug 30, 2024

Ah, I missed that. And no, I don't think mautrix-go will allow uninvited members to send messages either. So that would have to be added back in again.
In our test cases we explicitly invited the bot account and also logged in with the bot account to accept the invite.
If you have time please add it, or I can do it somewhere during the weekend or Monday.

@sebhoss
Copy link
Member

sebhoss commented Aug 30, 2024

Ok ok - let see who is faster 😄

edit: Or maybe a better approach would be to document who bot accounts can be created and added to rooms? Since that action is only necessary once I always thought that this room joining code was kinda annoying

internal/matrix/client.go Outdated Show resolved Hide resolved
internal/matrix/client.go Outdated Show resolved Hide resolved
internal/matrix/client.go Outdated Show resolved Hide resolved
fix room mapping
use format.HTMLToContent instead of our own HTMLMessage
@sebhoss sebhoss merged commit 0c1ba69 into metio:main Sep 2, 2024
3 checks passed
@sebhoss
Copy link
Member

sebhoss commented Sep 2, 2024

@metskem thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants