-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vueTemplate): add try catch on render function to avoid compiler error #53
feat(vueTemplate): add try catch on render function to avoid compiler error #53
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi again ! Use a I add a new function If it's not, I render markdown without vue render. I test it in production and it's work 😄. |
Hi. Sorry for delay. Thanks for the solution! However, I'm a little concerned that validating dom could be too heavy for this library. Maybe we could find a more light-weighted & elegant way to handle that error. BTW, please do not include |
Oh, sorry for the To be honest I spended my 3 last day on that error to try to find an solution, and it's the only solution that I found 😢. But I agree with you, this solution is pretty hard to just handle a error... I try a lot to find a way to handle error from After some investigation, I found that the real problem is, when I try to add So I conclude that, if I can't handle the error or reboot the component, my last solution is to prevent the error. I really need a fix now, even if it's not perfect (to be honnest in my use-case I don't really care about performance), so I will continue to use my version of the package, (I can't really take time to find another fix now), but if you have any idea or a potential fix, let me know, I would be happy to help 😃 |
Why is the MR closed? 😀 |
Add a
try...catch
to render function to avoid error ifvueTemplate
compiler encountered an error.To fix issue 52.
Sadly, I don't know how to run the package in production mode, so I can't test this solution to see if it's works correctly.
The behaviour expected is:
<UnknowComponent>
) withvueTemplate
enabled, render the code withouttemplate,
components
andsetup
vueTemplate
options.