Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rainfall dataset #136

Merged
merged 30 commits into from
Jan 29, 2025
Merged

Rainfall dataset #136

merged 30 commits into from
Jan 29, 2025

Conversation

tourniert
Copy link
Contributor

@tourniert tourniert commented Jan 27, 2025 •
edited
Loading

  • Adding a new Dataset to experiment py4cast framework on precipitation nowcasting.
  • Fix default projection_kwargsin Gridclass
  • Raise ValueError if one sample of the Dataset contain a Nan (else statistics are equal to Nan)

PRADEL BRUNO and others added 20 commits January 8, 2025 14:58
<rainfall> add RainfallAccessor
fe2a84a
rainfall dataset ongoing work
cab0ad5
<rainfall> updating cache_dir()
e5421f0
Merge branch 'main' into rainfall_dataset
d78ffc7 
Conflicts:
	py4cast/datasets/access.py
	py4cast/datasets/base.py
<dataset> fix init of projection_kwargs
57c27dd
<dataset> add app to prepare and describe dataset
33e0341
<dataset> removing tests for debug
167dab7
<dataset> add Rainfall to registry
bb20914
<dataset> add rainfall default config
9e267f4
<dataset> fix load_grid_info argument
4bae731
reformat for CI
29f872b
<dataset> add default args to Accessor.torch_dataloader
4539440
<rainfall> fix "levels" type (convert in list)
61ded94
<rainfall> change default num_input_steps = 4
68f199f
<dataset> reformat for CI
4e946c9
<rainfall> add plot and speed_test apps
44c010d
<dataset> change rainfall DEFAULT_CONFIG_DIR
256848c
<dataset> updating with dataset CLI
662f92c
<dataset> removing def test
4aafc20
<rainfall> reformat for CI
0a6c3b9
@LBerth
Copy link
Contributor

LBerth commented Jan 28, 2025

Can you put a small description of your PR please ? :)
You can also add a CLI/datasets/rainfall.yaml config file, to be used with Lightning CLI.

flyIchtus
flyIchtus reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@flyIchtus flyIchtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great pr :)
A single light comment for me

py4cast/datasets/poesy/__init__.py Show resolved Hide resolved
@flyIchtus flyIchtus merged commit ee99616 into meteofrance:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemoule clemoule clemoule approved these changes

@flyIchtus flyIchtus flyIchtus approved these changes

@LBerth LBerth Awaiting requested review from LBerth

@colon3ltocard colon3ltocard Awaiting requested review from colon3ltocard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tourniert @LBerth @flyIchtus @clemoule