Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and doc + refacto models + adds GNNs #13

Merged
merged 17 commits into from
Dec 9, 2024

Conversation

colon3ltocard
Copy link
Contributor

@colon3ltocard colon3ltocard commented Dec 4, 2024

  • Update Python dependencies
  • Fix metric test on GPU
  • Fix/improve README.md (NamedTensor and UNETR++)
  • Update torch version in Dockerfile
  • Makes sure unit test write model checkpoints in a temporary directory
  • Adds GNNs from py4cast
  • Adds a ModelType Enum + model_type attribute to classify models in arch families (graph, conv, vision_transformers, llm , ...)
  • Adds mandatory settings to model instance to make sure we always have access to all params used to setup a model
  • Adds mandatory num_spatial_dims attribute to model instance to be able to know at runtime if 1d, 2d or 3d instance
  • Adds boolean features_last mandatory attribute to models to allow callers to einops rearrange at runtime on a per model basis

tourniert
tourniert previously approved these changes Dec 5, 2024
@colon3ltocard colon3ltocard marked this pull request as ready for review December 5, 2024 11:56
@colon3ltocard colon3ltocard changed the title Update deps and doc Update deps and doc + refacto interface contract for models Dec 5, 2024
@colon3ltocard colon3ltocard changed the title Update deps and doc + refacto interface contract for models Update deps and doc + refacto models + adds GNNs Dec 6, 2024
mfai/torch/models/base.py Show resolved Hide resolved
mfai/torch/models/__init__.py Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
flyIchtus
flyIchtus previously approved these changes Dec 9, 2024
Copy link
Collaborator

@flyIchtus flyIchtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestion for the sake of error handling

mfai/torch/models/__init__.py Outdated Show resolved Hide resolved
@tourniert tourniert merged commit e4bb757 into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants