-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and doc + refacto models + adds GNNs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colon3ltocard
commented
Dec 4, 2024
•
edited
Loading
edited
- Update Python dependencies
- Fix metric test on GPU
- Fix/improve README.md (NamedTensor and UNETR++)
- Update torch version in Dockerfile
- Makes sure unit test write model checkpoints in a temporary directory
- Adds GNNs from py4cast
- Adds a ModelType Enum + model_type attribute to classify models in arch families (graph, conv, vision_transformers, llm , ...)
- Adds mandatory settings to model instance to make sure we always have access to all params used to setup a model
- Adds mandatory num_spatial_dims attribute to model instance to be able to know at runtime if 1d, 2d or 3d instance
- Adds boolean features_last mandatory attribute to models to allow callers to einops rearrange at runtime on a per model basis
tourniert
previously approved these changes
Dec 5, 2024
colon3ltocard
changed the title
Update deps and doc
Update deps and doc + refacto interface contract for models
Dec 5, 2024
colon3ltocard
changed the title
Update deps and doc + refacto interface contract for models
Update deps and doc + refacto models + adds GNNs
Dec 6, 2024
flyIchtus
reviewed
Dec 9, 2024
tourniert
requested changes
Dec 9, 2024
flyIchtus
previously approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor suggestion for the sake of error handling
Co-authored-by: ClémentBrochet <[email protected]>
flyIchtus
approved these changes
Dec 9, 2024
tourniert
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.