Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1945
API endpoint local queue params not working at all. I had investigate that the problem in Procedure class and originated from commit "Improve Procedure class PR-URL: #1569 " 434e6c1 Where was applied changes into constructor:
Object.assign(this, exp);
removedconcurrency
of the API endpoint was replaced withqueue
object containingqueue.concurrency
this.concurrency
not assigned directly anymore (as for example done forthis.parameters
.However methods
enter
andleave
still checkingthis.concurrency
for existance as of today.impress/lib/procedure.js
Lines 42 to 57 in 4cabe81
As a result local Semaphore of the Procedure never applied. There should be check for the property
this.semaphore
instead. It suitable for this purpose because it will benull
in case API endpoint doesn't provide queue settings.Before applying the fix I also added test case
lib/procedure queue
in /test/procedure.js . By the way I had fixed application stub in Procedure tests to make it comply with updated contract (was changed by #1898).npm t
)npm run fmt
)