Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check isFile for 404 before create stream #1897

Closed
wants to merge 1 commit into from
Closed

Check isFile for 404 before create stream #1897

wants to merge 1 commit into from

Conversation

tshemsedinov
Copy link
Member

@tshemsedinov tshemsedinov commented Sep 8, 2023 •
edited
Loading

Closes: #1896

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

tshemsedinov added a commit that referenced this pull request Sep 8, 2023
@tshemsedinov
Check isFile for 404 before create stream
dfb4d07 
Closes: #1896
PR-URL: #1897
@tshemsedinov
Copy link
Member Author

Landed in dfb4d07

@tshemsedinov tshemsedinov mentioned this pull request Sep 8, 2023
Closed
@tshemsedinov tshemsedinov mentioned this pull request Oct 3, 2023
Closed
@tshemsedinov tshemsedinov deleted the static-404 branch October 5, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HEADERS_SENT on node 20, server static from empty folder
1 participant
@tshemsedinov