Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor application places #1879

Closed
wants to merge 4 commits into from
Closed

Refactor application places #1879

wants to merge 4 commits into from

Conversation

tshemsedinov
Copy link
Member

@tshemsedinov tshemsedinov commented Jul 30, 2023 •
edited
Loading

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

tshemsedinov added a commit that referenced this pull request Jul 30, 2023
@tshemsedinov
Rename Place to Code
e604137 
PR-URL: #1879
tshemsedinov added a commit that referenced this pull request Jul 30, 2023
@tshemsedinov
Rename Cache to Place
a70596b 
PR-URL: #1879
tshemsedinov added a commit that referenced this pull request Jul 30, 2023
@tshemsedinov
Rename Place.place to Place.name
3422523 
PR-URL: #1879
tshemsedinov added a commit that referenced this pull request Jul 30, 2023
@tshemsedinov
Refactor Code.stop
989612c 
PR-URL: #1879
@tshemsedinov
Copy link
Member Author

Landed in e604137, a70596b, 3422523, and 989612c

@tshemsedinov tshemsedinov deleted the places branch October 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tshemsedinov