-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow: Use GCR for commenter and label_sync images #912
Prow: Use GCR for commenter and label_sync images #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Label sync job applied and confirmed working. The periodic stale is handled as a ProwJob so it is autoapplied on merge. |
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These components are not maintained in the new prow repo and have apparently not been pushed to the same staging registry. Instead they are pushed to the test-infra staging registry in GCR. This commit changes the registry for the commenter and label_sync jobs and updates the autobumper to detect these images as well. I also had to bump the tag of the images since they have not pushed old images to the same registry. Signed-off-by: Lennart Jern <[email protected]>
cde2324
to
19748ad
Compare
/override metal3-ubuntu-e2e-integration-test-main |
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lentzi90: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These components are not maintained in the new prow repo and have apparently not been pushed to the same staging registry. Instead they are pushed to the test-infra staging registry in GCR.
This commit changes the registry for the commenter and label_sync jobs and updates the autobumper to detect these images as well. I also had to bump the tag of the images since they have not pushed old image to the same registry.