Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Use GCR for commenter and label_sync images #912

Merged

Conversation

lentzi90
Copy link
Member

These components are not maintained in the new prow repo and have apparently not been pushed to the same staging registry. Instead they are pushed to the test-infra staging registry in GCR.

This commit changes the registry for the commenter and label_sync jobs and updates the autobumper to detect these images as well. I also had to bump the tag of the images since they have not pushed old image to the same registry.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@lentzi90
Copy link
Member Author

Label sync job applied and confirmed working. The periodic stale is handled as a ProwJob so it is autoapplied on merge.
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

Label sync job applied and confirmed working. The periodic stale is handled as a ProwJob so it is autoapplied on merge.
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
These components are not maintained in the new prow repo and have
apparently not been pushed to the same staging registry. Instead they
are pushed to the test-infra staging registry in GCR.

This commit changes the registry for the commenter and label_sync jobs
and updates the autobumper to detect these images as well. I also had to
bump the tag of the images since they have not pushed old images to the
same registry.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/prow-revert-test-infra-images branch from cde2324 to 19748ad Compare November 26, 2024 08:12
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
@lentzi90
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@metal3-io-bot metal3-io-bot merged commit d677cc9 into metal3-io:main Nov 26, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/prow-revert-test-infra-images branch November 26, 2024 08:17
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key periodics.yaml using file prow/config/jobs/periodics.yaml

In response to this:

These components are not maintained in the new prow repo and have apparently not been pushed to the same staging registry. Instead they are pushed to the test-infra staging registry in GCR.

This commit changes the registry for the commenter and label_sync jobs and updates the autobumper to detect these images as well. I also had to bump the tag of the images since they have not pushed old image to the same registry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants