Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert fullstack jobs to be prow compatible #887

Merged
merged 1 commit into from
Jan 15, 2025
Merged

convert fullstack jobs to be prow compatible #887

merged 1 commit into from
Jan 15, 2025

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Oct 31, 2024 •
edited
Loading

This PR:

  • Converts the previously mostly unused and outdated project_infra
    fullstack PR jobs to use prow triggers instead of "ghprb" triggers
  • Makes both the periodic and the PR fullstack jobs use the same prow
    compatible pipeline script
  • Removes the variable related to IPA git reference from the fullstack
    wrapper script as the IPA builder uses the branch name as reference.

This change is needed because the Metal3-io project does no longer uses the
Jenkins ghprb plugin, instead the PR jobs are triggered via GitHub or Prow.

@metal3-io-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Nov 6, 2024

/test fullstack

@metal3-io-bot
Copy link
Collaborator

@Rozzii: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test spellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-bml-integration-test-centos
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-basic-test-release-1-8
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-feature-test-release-1-6-features
  • /test metal3-centos-e2e-feature-test-release-1-6-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-6-remediation
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-centos-e2e-feature-test-release-1-8-features
  • /test metal3-centos-e2e-feature-test-release-1-8-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-8-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-centos-e2e-integration-test-release-1-8
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-centos-release-1-6
  • /test metal3-dev-env-integration-test-centos-release-1-7
  • /test metal3-dev-env-integration-test-centos-release-1-8
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-dev-env-integration-test-ubuntu-release-1-7
  • /test metal3-dev-env-integration-test-ubuntu-release-1-8
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-7
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-8
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-8
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-8
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config
  • shellcheck

In response to this:

/test fullstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@Rozzii Rozzii changed the title WIP: convert fullstack jobs to be prow compatible convert fullstack jobs to be prow compatible Jan 13, 2025
@Rozzii Rozzii marked this pull request as ready for review January 13, 2025 12:26
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@metal3-io-bot metal3-io-bot requested a review from mquhuy January 13, 2025 12:26
@Rozzii
Copy link
Member Author

Rozzii commented Jan 13, 2025

Integration test is not relevant here.
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

Integration test is not relevant here.
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii
convert fullstack jobs to be prow compatible
06f36c4 
This commit:
 - Converts the previously mostly unused and outdated project_infra
 fullstack PR jobs to use prow triggers instead of "ghprb" triggers
 - Makes both the periodic and the PR fullstack jobs use the same prow
 compatible pipeline script
 - Removes the variable related to IPA git reference from the fullstack
 wrapper script as the IPA builder uses the branch name as reference.

This change is needed because the Metal3-io project does no longer uses the
Jenkins ghprb plugin, instead the PR jobs are triggered via GitHub or Prow.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii Rozzii requested a review from tuminoid January 14, 2025 10:29
@Rozzii
Copy link
Member Author

Rozzii commented Jan 14, 2025

Integration test is not relevant here.
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Rozzii: Overrode contexts on behalf of Rozzii: metal3-ubuntu-e2e-integration-test-main

In response to this:

Integration test is not relevant here.
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
for more reviews.
/cc @Sunnatillo @lentzi90

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
lentzi90
lentzi90 reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jan 15, 2025

Is it okay to remove the hold ? @tuminoid or should I wait for third reviewer (I am a bit confused)?

@tuminoid
Copy link
Member

Is it okay to remove the hold ? @tuminoid or should I wait for third reviewer (I am a bit confused)?

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@metal3-io-bot metal3-io-bot merged commit d737fac into metal3-io:main Jan 15, 2025
6 checks passed
@metal3-io-bot metal3-io-bot deleted the fullstack_prow branch January 15, 2025 06:47
@metal3-io-bot
Copy link
Collaborator

@Rozzii: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key project-infra.yaml using file prow/config/jobs/metal3-io/project-infra.yaml

In response to this:

This PR:

  • Converts the previously mostly unused and outdated project_infra
    fullstack PR jobs to use prow triggers instead of "ghprb" triggers
  • Makes both the periodic and the PR fullstack jobs use the same prow
    compatible pipeline script
  • Removes the variable related to IPA git reference from the fullstack
    wrapper script as the IPA builder uses the branch name as reference.

This change is needed because the Metal3-io project does no longer uses the
Jenkins ghprb plugin, instead the PR jobs are triggered via GitHub or Prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mquhuy mquhuy Awaiting requested review from mquhuy

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozzii @metal3-io-bot @tuminoid @lentzi90