Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger BMO e2e tests through prow #618

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Trigger BMO e2e tests through prow #618

merged 1 commit into from
Jan 18, 2024

Conversation

lentzi90
Copy link
Member

This is to verify that the jenkins operator for prow works as expected. The idea is to trigger jenkins jobs through prow instead of through the ghprb jenkins plugin. When we have verified that this works, we can continue with the rest of the jenkins jobs and remove the ghprb triggers.

@lentzi90
Copy link
Member Author

/hold
This needs https://gerrit.nordix.org/c/infra/cicd/+/20350

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 17, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/bmo-e2e-prow-trigger branch 11 times, most recently from d005e70 to 74c4b6c Compare January 17, 2024 14:45
@lentzi90
Copy link
Member Author

Initial test: https://jenkins.nordix.org/job/lennart-test-bmo-e2e/13/console
I have here given it PULL_PULL_SHA=79af5f86f2a9cc0527c894be50aca371f830c8fb as parameter to see that it properly checks out the correct commit.
Results look good.

@lentzi90
Trigger BMO e2e tests through prow
9592756 
This is to verify that the jenkins operator for prow works as expected.
The idea is to trigger jenkins jobs through prow instead of through the
ghprb jenkins plugin. When we have verified that this works, we can
continue with the rest of the jenkins jobs and remove the ghprb
triggers. Then we can also update the required status checks and make
the prow-jenkins jobs required.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/bmo-e2e-prow-trigger branch from 74c4b6c to 9592756 Compare January 18, 2024 08:54
@lentzi90
Copy link
Member Author

Changed it now to keep the status checks and make the prow job optional. Once we have verified it is working I can update these things.

@lentzi90
Copy link
Member Author

/override test-ubuntu-integration-main
Irrelevant

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
Irrelevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
Sunnatillo
Sunnatillo reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lentzi90
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@metal3-io-bot metal3-io-bot merged commit 4a09202 into metal3-io:main Jan 18, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

This is to verify that the jenkins operator for prow works as expected. The idea is to trigger jenkins jobs through prow instead of through the ghprb jenkins plugin. When we have verified that this works, we can continue with the rest of the jenkins jobs and remove the ghprb triggers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo Sunnatillo deleted the lentzi90/bmo-e2e-prow-trigger branch January 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lentzi90 @metal3-io-bot @kashifest @tuminoid @Sunnatillo