Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BMO e2e tests required status check #615

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Jan 9, 2024

I propose we make the e2e tests required for BMO now. They exist on main and release-0.5 so this is what I added.
We could also remove one or both CAPM3 based jobs, but perhaps better to do that separately?

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2024
@lentzi90 lentzi90 force-pushed the lentzi90/bmo-e2e-required branch from 0447baf to 54d8528 Compare January 9, 2024 13:17
@lentzi90
Copy link
Member Author

lentzi90 commented Jan 9, 2024

/override test-ubuntu-integration-main
Irrelevant...

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
Irrelevant...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxrantil
Copy link

LGTM

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@metal3-io-bot metal3-io-bot merged commit f128c5d into metal3-io:main Jan 9, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

I propose we make the e2e tests required for BMO now. They exist on main and release-0.5 so this is what I added.
We could also remove one or both CAPM3 based jobs, but perhaps better to do that separately?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90 lentzi90 deleted the lentzi90/bmo-e2e-required branch January 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants