Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: export ironic and mariadb env vars coming from vars.sh #612

Closed
wants to merge 1 commit into from
Closed

WIP: export ironic and mariadb env vars coming from vars.sh #612

wants to merge 1 commit into from

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 22, 2023 •
edited
Loading

TL;DR: Those variables get lost between integration test start and 02 script trying to use them.

I'm testing metal3-io/ironic-image#466 Ironic source build after metal3-io/metal3-dev-env#1330 got merged, and from the log I can see IRONIC_FROM_SOURCE is set to true in project-infra, it gets into /tmp/vars.sh which is sourced in integration_test.sh but when the test says make ci_run and runs 02 script, which sources common.sh, the IRONIC_FROM_SOURCE variable is empty, and gets defaulted to false.

https://jenkins.nordix.org/job/metal3_ironic_image_main_integration_test_centos_ironic_from_source/10/consoleFull

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tuminoid. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid tuminoid changed the title export ironic and mariadb env vars coming from vars.sh WIP: export ironic and mariadb env vars coming from vars.sh Dec 22, 2023
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 22, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main-ironic-source

@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-integration-main-ironic-source

@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main-ironic-source

@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main-ironic-source

Does not work from project-infra, so cannot tell if it works or not. Need to fix JJB I guess.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@tuminoid
Copy link
Member Author

/retest
Just checking the new linters.

@tuminoid
Copy link
Member Author

/test markdownlint

@tuminoid
Copy link
Member Author

Testing random thing.

/test centos-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test shellcheck

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config
  • shellcheck

In response to this:

Testing random thing.

/test centos-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
export ironic and mariadb env vars coming from vars.sh
1138dc3 
They get lost between integration test start and 02 script trying to
use them.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main

@tuminoid
Copy link
Member Author

/test-centos-integration-main

@tuminoid
Copy link
Member Author

/test-centos-integration-main-ironic-source

1 similar comment
@tuminoid
Copy link
Member Author

/test-centos-integration-main-ironic-source

@tuminoid
Copy link
Member Author

/hold
This needs JJB changes to enable -ironic-source from project-infra too, not only from ironic-image.

@tuminoid
Copy link
Member Author

tuminoid commented Mar 1, 2024

Testing unrelated things:

/test-ubuntu-integration-main

New regex will trigger it...?

@tuminoid
Copy link
Member Author

This has rotten, will abandon for now.

/close

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Closed this PR.

In response to this:

This has rotten, will abandon for now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/fix-vars-sh branch March 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuminoid @metal3-io-bot