Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMO e2e: Allow flexible artifact naming #610

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

lentzi90
Copy link
Member

This is needed before we can add a matrix to the pipeline. Otherwise the parallel tests would overwrite each others artifacts...

This is needed before we can add a matrix to the pipeline. Otherwise
the parallel tests would overwrite each others artifacts...

Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2023
@lentzi90 lentzi90 force-pushed the lentzi90/bmo-e2e-artifacts branch from 5aeb494 to 1d20d07 Compare December 21, 2023 13:11
@mquhuy
Copy link
Member

mquhuy commented Dec 21, 2023

/lgtm

@metal3-io-bot
Copy link
Collaborator

@mquhuy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@lentzi90
Copy link
Member Author

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@metal3-io-bot metal3-io-bot merged commit edc27c6 into metal3-io:main Dec 21, 2023
2 checks passed
@lentzi90 lentzi90 deleted the lentzi90/bmo-e2e-artifacts branch December 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants