Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct variable name for Ironic local build #609

Merged
merged 1 commit into from
Dec 20, 2023
Merged

use correct variable name for Ironic local build #609

merged 1 commit into from
Dec 20, 2023

Conversation

tuminoid
Copy link
Member

BUILD_IRONIC_LOCALLY -> BUILD_IRONIC_IMAGE_LOCALLY. Latter is a a config recognized by dev-env.

@tuminoid
use correct variable name for Ironic local build
97e2f11 
BUILD_IRONIC_LOCALLY -> BUILD_IRONIC_IMAGE_LOCALLY. Latter is a
a config recognized by dev-env.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
smoshiur1237
smoshiur1237 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@tuminoid
Copy link
Member Author

/cc @lentzi90 @Rozzii

Rozzii
Rozzii approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

lentzi90
lentzi90 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@metal3-io-bot metal3-io-bot merged commit ce09c1f into metal3-io:main Dec 20, 2023
5 checks passed
@tuminoid tuminoid deleted the tuomo/fix-ironic-image-build branch December 20, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @lentzi90 @Rozzii @smoshiur1237