-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jenkins-operator for prow #608
Add jenkins-operator for prow #608
Conversation
The name is a bit misleading unfortunately. This prow component is used to trigger jenkins jobs. It will allow us to have one common way to trigger all tests (except github workflows) and we can stop using the ghprb jenkins plugin that is no longer maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be silly of me, but we have done all other resource requests as a separate patch so I did the same here also.
Not relevant |
@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks nice! How do we plan to test it? |
The jenkins-operator has already been installed in the cluster, but the config change has not been applied. That will happen when we merge this. The part that I could not test is the deck integration that should allow it to display logs from jenkins. However, I have confirmed that it is possible to get the logs by curling the jenkins-operator pod directly so I'm relatively sure that it will work. After we merge this, we will still need to add trigger configurations for all jobs that we want to trigger in this way. I think we should do that separately though, and perhaps not all jobs at once. We could for example start with the BMO e2e jobs that are currently not required as a low risk first step. Edit: All jenkins job that we want to trigger this way must also have two parameters that the jenkins-operator is using: |
Sounds fair! Timing just before holiday vacations though. It sounds like we can merge this, but maybe not mess with JJB and triggers just yet? /approve |
Yeah that makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smoshiur1237, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lentzi90: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The name is a bit misleading unfortunately. This prow component is used to trigger jenkins jobs. It will allow us to have one common way to trigger all tests (except github workflows) and we can stop using the ghprb jenkins plugin that is no longer maintained.