Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins-operator for prow #608

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

lentzi90
Copy link
Member

The name is a bit misleading unfortunately. This prow component is used to trigger jenkins jobs. It will allow us to have one common way to trigger all tests (except github workflows) and we can stop using the ghprb jenkins plugin that is no longer maintained.

The name is a bit misleading unfortunately. This prow component is used
to trigger jenkins jobs. It will allow us to have one common way to
trigger all tests (except github workflows) and we can stop using the
ghprb jenkins plugin that is no longer maintained.
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be silly of me, but we have done all other resource requests as a separate patch so I did the same here also.

@lentzi90
Copy link
Member Author

Not relevant
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: test-ubuntu-integration-main

In response to this:

Not relevant
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

Looks nice! How do we plan to test it?

@lentzi90
Copy link
Member Author

lentzi90 commented Dec 20, 2023

The jenkins-operator has already been installed in the cluster, but the config change has not been applied. That will happen when we merge this.
To test these changes I have applied the jenkins-operator manifests manually and configured it to use a separate configmap instead of the auto-synced. Then I created a prow job and applied it to see that the jenkins-operator was able to trigger the jenkins job. This worked well.

The part that I could not test is the deck integration that should allow it to display logs from jenkins. However, I have confirmed that it is possible to get the logs by curling the jenkins-operator pod directly so I'm relatively sure that it will work.

After we merge this, we will still need to add trigger configurations for all jobs that we want to trigger in this way. I think we should do that separately though, and perhaps not all jobs at once. We could for example start with the BMO e2e jobs that are currently not required as a low risk first step.

Edit: All jenkins job that we want to trigger this way must also have two parameters that the jenkins-operator is using: BUILD_ID and PROW_JOB_ID. We need to add this in JJB.

@tuminoid
Copy link
Member

Sounds fair! Timing just before holiday vacations though. It sounds like we can merge this, but maybe not mess with JJB and triggers just yet?

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@lentzi90
Copy link
Member Author

Yeah that makes sense!

@tuminoid
Copy link
Member

/cc @Sunnatillo @smoshiur1237

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 0b6d893 into metal3-io:main Dec 21, 2023
1 check passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

The name is a bit misleading unfortunately. This prow component is used to trigger jenkins jobs. It will allow us to have one common way to trigger all tests (except github workflows) and we can stop using the ghprb jenkins plugin that is no longer maintained.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90 lentzi90 deleted the lentzi90/prow-jenkins-operator branch December 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants