Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 🌱 Add scalablity test with fakeIPA #1954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: 🌱 Add scalablity test with fakeIPA #1954

wants to merge 2 commits into from

Conversation

mboukhalfa
Copy link
Member

WIP testing fakeIPA with e2e

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboukhalfa. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2024
@mboukhalfa
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

2 similar comments
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mquhuy
Copy link
Member

mquhuy commented Sep 19, 2024

@mboukhalfa We've been discussing on how to uncouple capm3 e2e from dev-env. Is it possible to design functions to run/configure fake-ipa in capm3, instead of relying on dev-env?

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 5b00b35 to f6e58cb Compare September 19, 2024 12:06
@tuminoid
Copy link
Member

/retitle WIP: 🌱 Add scalablity test with fakeIPA
let's make it clear it is not intended to be merged as-is (points to private forks etc)

@metal3-io-bot metal3-io-bot changed the title 🌱 Add scalablity test with fakeIPA WIP: 🌱 Add scalablity test with fakeIPA Sep 20, 2024
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from f6e58cb to 977bb89 Compare September 26, 2024 10:13
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch 2 times, most recently from 6d26c4b to 50b7af2 Compare September 27, 2024 15:26
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch 8 times, most recently from 97777c8 to ab9a769 Compare October 7, 2024 12:53
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch 2 times, most recently from 8c85224 to 05e18bb Compare October 10, 2024 11:37
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 05e18bb to 32a2b1f Compare October 21, 2024 11:26
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 32a2b1f to 1099be2 Compare October 21, 2024 11:33
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 1099be2 to af25d28 Compare October 21, 2024 11:34
@mquhuy
Copy link
Member

mquhuy commented Oct 21, 2024

Question: Is this test supposed to add FKAS integration later on, or will that be a separate test(s)?

@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from af25d28 to a498ad5 Compare October 21, 2024 11:36
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 21, 2024
@mboukhalfa
Copy link
Member Author

mboukhalfa commented Oct 21, 2024 •
edited
Loading

Question: Is this test supposed to add FKAS integration later on, or will that be a separate test(s)?

This test already uses the FKAS

@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from a498ad5 to c1d5832 Compare October 21, 2024 11:39
@mboukhalfa
Add Scalability test
2fcf2d7 
Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa
Use basic trigger to test the PR
ddb80de 
Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from c1d5832 to ddb80de Compare October 21, 2024 11:43
@mboukhalfa
Copy link
Member Author

test ?

@mquhuy
Copy link
Member

mquhuy commented Oct 21, 2024

This test already uses the FKAS

Thanks. There was another PR which I think only scaled to 1000 BMHs. Is that a different test?

@mboukhalfa
Copy link
Member Author

/hold
This test is using the basic test as a trigger for test purposes while waiting for the scalability pipeline to be merged. It also currently uses the Nordix branch of the CAPI test suite since there are some changes needed in CAPI to enable reusing the test with legacy templates instead of duplicating it here in CAPM3. Additionally, it is still using the Nordix branch to incorporate FakeIPA and FKAS, pending the merge of the associated PR.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@mboukhalfa
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • markdownlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-mai

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gomod
  • manifestlint
  • markdownlint
  • shellcheck
  • test
  • unit

In response to this:

/test metal3-centos-e2e-basic-test-mai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test ddb80de link true /test test
metal3-centos-e2e-basic-test-main ddb80de link false /test metal3-centos-e2e-basic-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test ddb80de link true /test test
metal3-centos-e2e-basic-test-main ddb80de link false /test metal3-centos-e2e-basic-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest Awaiting requested review from kashifest

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mboukhalfa @metal3-io-bot @mquhuy @tuminoid