-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix minor issues in the API help strings #1936
Conversation
/cc @zaneb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -833,7 +832,7 @@ type BareMetalHostStatus struct { | |||
// The last error message reported by the provisioning subsystem. | |||
ErrorMessage string `json:"errorMessage"` | |||
|
|||
// Whether or not the host is currently powered on. This field may get | |||
// The currently detected power state of the host. This field may get | |||
// briefly out of sync with the actual state of the hardware while | |||
// provisioning processes are running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant we could say 'currently detected' instead of all the stuff about being briefly out of sync.
I feel like it goes without saying that we are in a distributed system and detection is not instananeous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep the second part here because it's a common source of confusion.
/lgtm |
Follow-up to commit 9a30c0d. Signed-off-by: Dmitry Tantsur <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Follow-up to commit 9a30c0d.
Signed-off-by: Dmitry Tantsur [email protected]