Avoid locally scoped variable issue.

metal3-io · Oct 14, 2024 · a327bf3 · a327bf3
1 parent 8e93c18
commit a327bf3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/controllers/metal3.io/baremetalhost_controller.go b/controllers/metal3.io/baremetalhost_controller.go
@@ -1391,7 +1391,9 @@ func (r *BareMetalHostReconciler) checkServicing(prov provisioner.Provisioner, i
 	}
 
 	if servicingData.LiveFirmwareSettingsAllowed {
-		hfsDirty, hfs, err := r.getHostFirmwareSettings(info)
+		var hfs *metal3api.HostFirmwareSettings
+		var err error
+		hfsDirty, hfs, err = r.getHostFirmwareSettings(info)
 		if err != nil {
 			info.log.Info(fmt.Sprintf("janders-debug: r.getHostFirmwareSettings failed: %q", err))
 			return actionError{fmt.Errorf("could not determine updated settings: %w", err)}, false