Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware validation: save work from Vince #52

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ofaurax
Copy link
Contributor

@ofaurax ofaurax commented Jan 17, 2025

From Vince:

I refactored the firmware validation function in flipflop to use a "low-level" Supermicro handle. The structure of code is reworked a bit as well, and I defined some internal interfaces to make mocking and testing a little easier. I also added a test for our firmware validation routine.

@ofaurax ofaurax mentioned this pull request Jan 17, 2025
@ofaurax ofaurax force-pushed the ofa-validation-integration branch from 4b72a4b to 96e0bd2 Compare January 29, 2025 10:40
internal/flipflop/validation_client.go Dismissed Show dismissed Hide dismissed
@ofaurax ofaurax force-pushed the ofa-validation-integration branch from 96e0bd2 to 894b95f Compare January 29, 2025 10:42
I imported a pre-release version of bmclib to get access to the new
versions of the supermicro client object. Using that I defined some
minimalist interfaces and used mockery to provide test collateral.
@ofaurax ofaurax force-pushed the ofa-validation-integration branch from 894b95f to 0f28e86 Compare February 4, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants