Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix neighbor interface name #120

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Fix neighbor interface name #120

merged 7 commits into from
Feb 21, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Feb 21, 2024 •
edited
Loading

TODO:

  • test with SONiC

Before:

  nics:                                                                                                                                                                                                                                       
  - identifier: ""                                                                                                                                                                                                                            
    mac: b4:96:91:49:95:d0                                                                                                                                                                                                                    
    name: eth0                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: b4:96:91:49:95:d1                                                                                                                                                                                                                    
    name: eth1                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: b4:96:91:49:95:d2                                                                                                                                                                                                                    
    name: eth2                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: b4:96:91:49:95:d3                                                                                                                                                                                                                    
    name: eth3                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: ac:1f:6b:7b:ed:30                                                                                                                                                                                                                    
    name: eth4                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: b8:6a:97:74:00:49                                                                                                                                                                                                           
      mac: b8:6a:97:74:00:49                                                                                                                                                                                                                  
      name: eth4                                                                                                                                                                                                                              
      neighbors: []                                                                                                                                                                                                                           
  - identifier: ""                                                                                                                                                                                                                            
    mac: ac:1f:6b:7b:ed:31                                                                                                                                                                                                                    
    name: eth5                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: b8:6a:97:73:f8:49                                                                                                                                                                                                           
      mac: b8:6a:97:73:f8:49                                                                                                                                                                                                                  
      name: eth5                                                                                                                                                                                                                              
      neighbors: []                                                                                                                                                                                                                           
  - identifier: ""                                                                                                                                                                                                                            
    mac: "00:00:00:00:00:00"                                                                                                                                                                                                                  
    name: lo                                                                                                                                                                                                                                  
    neighbors: []

After:

  nics:                                                                                                                                                                                                                                       
  - identifier: ""                                                                                                                                                                                                                            
    mac: 3c:ec:ef:22:fc:1a                                                                                                                                                                                                                    
    name: eth0                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: 3c:ec:ef:22:fc:1b                                                                                                                                                                                                                    
    name: eth1                                                                                                                                                                                                                                
    neighbors: []                                                                                                                                                                                                                             
  - identifier: ""                                                                                                                                                                                                                            
    mac: 50:7c:6f:16:c5:a8                                                                                                                                                                                                                    
    name: eth2                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: b8:6a:97:74:00:56                                                                                                                                                                                                           
      mac: b8:6a:97:74:00:56                                                                                                                                                                                                                  
      name: swp7s3                                                                                                                                                                                                                            
      neighbors: []                                                                                                                                                                                                                           
  - identifier: ""                                                                                                                                                                                                                            
    mac: 50:7c:6f:16:c5:a9                                                                                                                                                                                                                    
    name: eth3                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: b8:6a:97:73:f8:56                                                                                                                                                                                                           
      mac: b8:6a:97:73:f8:56                                                                                                                                                                                                                  
      name: swp7s3                                                                                                                                                                                                                            
      neighbors: []                                                                                                                                                                                                                           
  - identifier: ""                                                                                                                                                                                                                            
    mac: "00:00:00:00:00:00"                                                                                                                                                                                                                  
    name: lo                                                                                                                                                                                                                                  
    neighbors: []

And on SONiC:

  nics:                                                                                                                                                                                                                                       
  - identifier: ""                                                                                                                                                                                                                            
    mac: 3c:ec:ef:d8:be:d8                                                                                                                                                                                                                    
    name: eth0                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: Eth15/2(Port15)                                                                                                                                                                                                             
      mac: Eth15/2(Port15)                                                                                                                                                                                                                    
      name: Ethernet57                                                                                                                                                                                                                        
      neighbors: []                                                                                                                                                                                                                           
  - identifier: ""                                                                                                                                                                                                                            
    mac: 3c:ec:ef:d8:be:d9                                                                                                                                                                                                                    
    name: eth1                                                                                                                                                                                                                                
    neighbors:                                                                                                                                                                                                                                
    - identifier: Eth15/2(Port15)                                                                                                                                                                                                             
      mac: Eth15/2(Port15)                                                                                                                                                                                                                    
      name: Ethernet57                                                                                                                                                                                                                        
      neighbors: []

@majst01 majst01 marked this pull request as ready for review February 21, 2024 14:41
@majst01 majst01 requested a review from a team as a code owner February 21, 2024 14:41
@majst01 majst01 merged commit 4920443 into master Feb 21, 2024
1 check passed
@majst01 majst01 deleted the fix-neighbor-interface-name branch February 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majst01 @Gerrit91