-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow the API to toggle switch ports #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrichSchreiner
force-pushed
the
toggle-switch-port
branch
4 times, most recently
from
February 26, 2024 14:24
f26a3d6
to
7c8d310
Compare
ulrichSchreiner
force-pushed
the
toggle-switch-port
branch
from
February 26, 2024 14:31
7c8d310
to
dd6d7f5
Compare
majst01
reviewed
Apr 4, 2024
majst01
reviewed
Apr 8, 2024
majst01
approved these changes
Apr 8, 2024
We should run the small integration test suite with this deployed in test, then merge |
Gerrit91
reviewed
Apr 22, 2024
Gerrit91
reviewed
Apr 23, 2024
Gerrit91
reviewed
Apr 23, 2024
Gerrit91
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API enables the user to toggle a port of a switch. The endpoint is
/switch/{id}/port
and the post body containsWhen this endpoint is invoked, the system stores the
status
as the new desired state (if it differs from the current state). The switch uses metal-core to regularly fetch the switch state. If it finds a desired state which differs from the current state, it will change the switch configuration to reflect this state and send a notification to/switch/{id}/notify
and report the new state. If the new state is equal to the desired state, metal-api will store this new state and remove the desired state from the persistence layer.Dependencies: