Prevent parallel allocation to ensure spreading and reservations. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible optimization would be to lock with the partition key such that allocations can go in parallel in different partitions. |
|
Now locked by partition key. |
ulrichSchreiner
approved these changes
May 27, 2024
majst01
reviewed
May 27, 2024
majst01
reviewed
May 27, 2024
majst01
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation implements a lock / mutex through the RethinkDB. I hope the tests I wrote are good enough to build trust into this idea as I think the advantages of having spread and reservations truly work are pretty big. If someone has a better idea to achieve the same outcome, please let me know.