Make firewall rules optional in machine response. (#503)

metal-stack · Feb 15, 2024 · c9e4944 · c9e4944
1 parent ae33d76
commit c9e4944
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cmd/metal-api/internal/service/v1/machine.go b/cmd/metal-api/internal/service/v1/machine.go
@@ -43,7 +43,7 @@ type MachineAllocation struct {
 	Role             string                    `json:"role" enum:"machine|firewall" description:"the role of the machine"`
 	VPN              *MachineVPN               `json:"vpn" description:"vpn connection info for machine" optional:"true"`
 	AllocationUUID   string                    `json:"allocationuuid" description:"a unique identifier for this machine allocation, can be used to distinguish between machine allocations over time."`
-	FirewallRules    *FirewallRules            `json:"firewall_rules" description:"a set of firewall rules to apply"`
+	FirewallRules    *FirewallRules            `json:"firewall_rules,omitempty" description:"a set of firewall rules to apply" optional:"true"`
 }
 
 type FirewallRules struct {

diff --git a/spec/metal-api.json b/spec/metal-api.json
@@ -2176,7 +2176,6 @@
         "allocationuuid",
         "created",
         "creator",
-        "firewall_rules",
         "hostname",
         "name",
         "networks",