check for old value and only update if new values differ

metal-stack · Jan 24, 2024 · 3bc65fc · 3bc65fc
1 parent ac01058
commit 3bc65fc
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/controllers/clusterwidenetworkpolicy_controller.go b/controllers/clusterwidenetworkpolicy_controller.go
@@ -239,6 +239,11 @@ func (r *ClusterwideNetworkPolicyReconciler) allowedCWNPs(ctx context.Context, c
 }
 
 func (r *ClusterwideNetworkPolicyReconciler) updateCWNPState(ctx context.Context, cwnp firewallv1.ClusterwideNetworkPolicy, state firewallv1.PolicyDeploymentState, msg string) error {
+	// do nothing if message and state already have the desired values
+	if cwnp.Status.Message == msg && cwnp.Status.State == state {
+		return nil
+	}
+
 	cwnp.Status.Message = msg
 	cwnp.Status.State = state