drop support for metacpan_script #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need metacpan_script for anything our code uses, and supporting it complicates our query filtering and interactions with Elasticsearch. We've generally been trying to move away from users interacting via Elasticsearch queries, but if they really need to and need a specific script, they are always welcome to submit a PR to the API adding what they need.
oalders
approved these changes
Apr 30, 2024
oalders
approved these changes
Apr 30, 2024
|
Wrong PR for that comment ^^. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1205 +/- ##
==========================================
+ Coverage 60.03% 60.06% +0.02%
==========================================
Files 168 168
Lines 4544 4542 -2
Branches 663 662 -1
==========================================
Hits 2728 2728
+ Misses 1574 1573 -1
+ Partials 242 241 -1 ☔ View full report in Codecov by Sentry. |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need metacpan_script for anything our code uses, and supporting it complicates our query filtering and interactions with Elasticsearch.
We've generally been trying to move away from users interacting via Elasticsearch queries, but if they really need to and need a specific script, they are always welcome to submit a PR to the API adding what they need.