Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tokenizer_path optional #182

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Make tokenizer_path optional #182

merged 2 commits into from
Oct 19, 2024

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Oct 19, 2024 •
edited
Loading

We have Tokenizer.get_instance() which looks up the default path using the baked in tokenizer.model in the repository anyway.

Ashwin Bharambe and others added 2 commits October 18, 2024 21:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 19, 2024
@ashwinb ashwinb changed the title Simplify tokenizer Make tokenizer_path optional Oct 19, 2024
raghotham
raghotham approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to show example runs with default and with explicitly specified tokenizer path.

@ashwinb ashwinb merged commit 6940e56 into main Oct 19, 2024
3 of 4 checks passed
@ashwinb ashwinb deleted the simplify_tokenizer branch October 19, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsaniket007 itsaniket007 itsaniket007 approved these changes

@raghotham raghotham raghotham approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwinb @raghotham @itsaniket007 @facebook-github-bot