Don't build a target by clicking its node, expand the node instead.

Added an inline build button on a target node.
mesonbuild · Nov 23, 2023 · d440673 · d440673
1 parent 34545bd
commit d440673
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -443,19 +443,24 @@
           "group": "build@2"
         },
         {
-          "command": "mesonbuild.openBuildFile",
+          "command": "mesonbuild.node.build",
           "when": "view == meson-project && viewItem == meson-target",
-          "group": "inline"
+          "group": "inline@0"
         },
         {
           "command": "mesonbuild.openBuildFile",
           "when": "view == meson-project && viewItem == meson-target",
-          "group": "build"
+          "group": "inline@1"
         },
         {
           "command": "mesonbuild.node.build",
           "when": "view == meson-project && viewItem == meson-target",
-          "group": "build"
+          "group": "build@0"
+        },
+        {
+          "command": "mesonbuild.openBuildFile",
+          "when": "view == meson-project && viewItem == meson-target",
+          "group": "build@1"
         },
         {
           "command": "mesonbuild.node.runAll",

diff --git a/src/treeview/nodes/targets.ts b/src/treeview/nodes/targets.ts
@@ -103,7 +103,7 @@ export class TargetNode extends BaseNode implements IBuildableNode {
     }
   }
 
-  override async getTreeItem() {
+  override getTreeItem() {
     const item = super.getTreeItem() as vscode.TreeItem;
 
     item.label = this.target.name;
@@ -112,14 +112,6 @@ export class TargetNode extends BaseNode implements IBuildableNode {
     item.collapsibleState = vscode.TreeItemCollapsibleState.Collapsed;
     item.contextValue = "meson-target";
 
-    const targetName = await getTargetName(this.target);
-
-    item.command = {
-      title: `Build ${this.target.name}`,
-      command: "mesonbuild.build",
-      arguments: [targetName],
-    };
-
     return item;
   }