Fix typing for most of the AST module #12633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/type-fix-most-of-ast
branch
from
85487ac
to
8c5dfad
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dcbaker
force-pushed
the
submit/type-fix-most-of-ast
branch
from
8c5dfad
to
35feedc
Compare
tristan957
approved these changes
Dec 15, 2023
eli-schwartz
reviewed
Jan 1, 2024
Other than one case that I think cannot be actually hit (or it would fail).
They already are warning free
dcbaker
force-pushed
the
submit/type-fix-most-of-ast
branch
from
35feedc
to
641ea7d
Compare
tristan957
approved these changes
Jan 8, 2024
eli-schwartz
reviewed
Jan 9, 2024
| @@ -270,7 +271,7 @@ def traverse_nodes(inqueue: T.List[BaseNode]) -> T.List[BaseNode]: | |||
| empty_sources: T.List[T.Any] = [] | |||
| # Passing the unresolved sources list causes errors | |||
| kwargs_reduced['_allow_no_sources'] = True | |||
| target = targetclass(name, self.subdir, self.subproject, for_machine, empty_sources, [], objects, | |||
| target = targetclass(name, self.subdir, self.subproject, for_machine, empty_sources, None, objects, | |||
There was a problem hiding this comment.
Oh fun... if self.structured_sources and an empty list is falsey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What remains is more complicated because of layering violations that will be difficult to fix