-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkers: fix LLD linker response file handling #12252
Merged
dcbaker
merged 1 commit into
mesonbuild:master
from
benoit-pierre:pr/fix_response_files_handling
Aug 9, 2024
Merged
linkers: fix LLD linker response file handling #12252
dcbaker
merged 1 commit into
mesonbuild:master
from
benoit-pierre:pr/fix_response_files_handling
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
September 14, 2023 10:10
01b5d43
to
f7bfbd6
Compare
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
December 24, 2023 19:07
f7bfbd6
to
11425e3
Compare
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
August 7, 2024 10:31
11425e3
to
8ed8cfb
Compare
Could you rebase for a fresh CI run now #11715 is in? |
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
August 7, 2024 14:38
8ed8cfb
to
cee5155
Compare
thesamesam
approved these changes
Aug 7, 2024
dcbaker
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise this looks good.
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
August 9, 2024 15:05
cee5155
to
6a17a09
Compare
eli-schwartz
reviewed
Aug 9, 2024
Correct base classes so GNU-like linkers all default to supporting response files.
benoit-pierre
force-pushed
the
pr/fix_response_files_handling
branch
from
August 9, 2024 17:22
6a17a09
to
63cfb29
Compare
dcbaker
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with LLD as the linker, response files are never used.
It's because of an issue with the
LLVMDynamicLinker
class hierarchy:After correcting the base classes so GNU-like linkers all default to supporting response files:
I added a test, but the CI would also need a build that actually use LLD as a linker.