Skip to content

Commit

Permalink
chore: doc
Browse files Browse the repository at this point in the history
  • Loading branch information
BANG88 committed Feb 24, 2018
1 parent c55973d commit 62a2f89
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,26 @@ and run `carthage update` when you done this you can link it like Manual link fr
```
3. Insert the following lines inside the dependencies block in `android/app/build.gradle`:
```
compile project(':@merryjs/photo-viewer')
compile project(':@merryjs/photo-viewer')
```
4. **Workaround for older gradles** please see https://github.com/merryjs/photo-viewer/issues/39

```
include ':merryjs-photo-viewer'
project(':merryjs-photo-viewer').projectDir = new File(rootProject.projectDir, '../node_modules/@merryjs/photo-viewer/android')
```
```
include ':merryjs-photo-viewer'
project(':merryjs-photo-viewer').projectDir = new File(rootProject.projectDir,'../node_modules/@merryjs/photo-viewer/android')
```

```
compile project(':merryjs-photo-viewer')
```

```
compile project(':merryjs-photo-viewer')
```
#### Android targetSdkVersion configuration

We use a third part library and both of them are target to `targetSdkVersion 25`, so you need update your build.gradle to the same version or you will meet a build error

The configuration looks like: (`android/app/build.gradle`)

```java

android {
compileSdkVersion 25
buildToolsVersion "25.0.3"
Expand All @@ -135,7 +135,7 @@ android {
}
// ...
}
````
```

If we have any better solution will update this section in the future.

Expand Down

0 comments on commit 62a2f89

Please sign in to comment.