Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed journey diagram box resizing issue #6248

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nour0205
Copy link

@nour0205 nour0205 commented Feb 1, 2025

📑 Summary

This PR fixes the box resizing issue in Journey Diagrams where text overflow was causing the boxes to be cropped instead of expanding properly.

Resolves #6243

📏 Design Decisions

Updated the width calculations to ensure that boxes automatically adjust their size based on the text length.

Modified SVG rendering logic to respect useMaxWidth and dynamically scale elements while maintaining readability.

Updated snapshot tests to align with the expected new behavior of auto-resizing boxes

📋 Tasks

Make sure you

  • [x ] 📖 have read the contribution guidelines
  • [x ] 💻 have added necessary unit/e2e tests.
  • [ x] 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • [x ] 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 1, 2025
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 311e046
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/679e8c8bc1c3f10008cfdd57
😎 Deploy Preview https://deploy-preview-6248--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6248
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6248
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6248
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6248

commit: 311e046

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (e9e663f) to head (311e046).
Report is 76 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% 35 Missing ⚠️
...rmaid/src/diagrams/user-journey/journeyRenderer.ts 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6248   +/-   ##
=======================================
  Coverage     4.47%   4.47%           
=======================================
  Files          385     385           
  Lines        54180   54156   -24     
  Branches       598     598           
=======================================
  Hits          2425    2425           
+ Misses       51755   51731   -24     
Flag Coverage Δ
unit 4.47% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rmaid/src/diagrams/user-journey/journeyRenderer.ts 0.00% <0.00%> (ø)
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxes do not automatically adjust with large amount of text in Journey Diagram
1 participant