Preventing requests to the AnalyticsURL if it is not set #1531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
I noticed that my self-hosted Mermaid Live Editor is sending requests to the analytics URL when I didn't set the analytics URL and the mermaid domain, and I believe it should be configured according to the instructions provided in the https://github.com/mermaid-js/mermaid-live-editor?tab=readme-ov-file#to-configure-analytics.
My expectation is that the Mermaid Live Editor should not be sending requests to the analytics URL because, according to the README, the default setting is empty, which disables analytics.
Therefore, I would like to make changes to address this issue.
Brief description about the content of your PR:
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable:
📋 Tasks
Make sure you
develop
branch