Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing requests to the AnalyticsURL if it is not set #1531

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

emahiro
Copy link

@emahiro emahiro commented Sep 7, 2024

📑 Summary

I noticed that my self-hosted Mermaid Live Editor is sending requests to the analytics URL when I didn't set the analytics URL and the mermaid domain, and I believe it should be configured according to the instructions provided in the https://github.com/mermaid-js/mermaid-live-editor?tab=readme-ov-file#to-configure-analytics.

My expectation is that the Mermaid Live Editor should not be sending requests to the analytics URL because, according to the README, the default setting is empty, which disables analytics.

Therefore, I would like to make changes to address this issue.

Brief description about the content of your PR:

  • Default env value is empty.
  • Prevent to request to mermaid.live for analytics if analyticsURL is not set.
  • analytics information is better to be empty because of default behavior at README

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 976f239
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/66eefd45868a650008ea49f2
😎 Deploy Preview https://deploy-preview-1531--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant