Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap standard for neostandard #1109

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

voxpelli
Copy link
Contributor

@voxpelli voxpelli commented Sep 5, 2024

Follows fastify etc, see eg. fastify/fastify#5509

(Disclaimer: I created neostandard together with Matteo and others and I was/is a co-maintainer of standard)

@mcollina
Copy link
Collaborator

mcollina commented Sep 5, 2024

CI fails :(

@mcollina
Copy link
Collaborator

mcollina commented Sep 5, 2024

you can bump minimum node to v20

@voxpelli
Copy link
Contributor Author

voxpelli commented Sep 5, 2024

@mcollina Done 👍

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 98ed90e into mercurius-js:master Sep 5, 2024
7 checks passed
@voxpelli voxpelli mentioned this pull request Sep 6, 2024
8 tasks
@voxpelli voxpelli deleted the neostandard branch September 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants