Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction details into create payment request body #319

Closed

Conversation

miguelvelasquezdev
Copy link

@miguelvelasquezdev miguelvelasquezdev commented Apr 24, 2024

📝 Description

Hi, I am Miguel Velasquez and I am a Latin American OSS enthusiast developer.

I've been using your node js sdk and i got a non understandable error while trying to create a payment with PSE, for a few hours I understood why I got the error 😅.

So I was not sending the financial institution because the sdk types had not that property in the request body types.

This was the error message:

{
  message: 'Invalid value',
  error: 'bad_request',
  status: 400,
   cause: [
    {
      code: 19,
      description: 'Invalid value',
      data: '24-04-2024T22:04:32UTC;36114152-c826-42e1-9b5e-e802e769c30d'
     }
  ]
}

It was in the docs, so fortunately I solved the problem.

I hope this little contribution help someone else!

✅ Checklist:

  • I followed the instructions indicated in Contribution Guidelines
  • I added the changes to CHANGELOG
  • Added the necessary tests for the code or functionality that I'm working on
  • I ran the tests and made sure they work
  • My branch coverage is at least 80%
  • I verified the style of my code matches the one in the project

🧰 How to reproduce

  • Not Apply.
  • Step by step of how to test, specially for bugs.
  • Links of external docs.

📸 Screenshots

  • Not Apply.
  • Before and after, if it's a fix for a bug.

📄 References

  • Not Apply.
  • Links do external documentation.
  • Diagrams.
  • Useful links.

@danielen-meli
Copy link
Contributor

Hello @miguelvelasquezdev,

We appreciate your contribution.
Unfortunately, your PR had a problem in our workflow, but we have already provided the correction and it will be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants