Add support for Aston Martin Smartire TPMS sensor, Vantage DB9 protocol #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/devices/tpms_aston_martin.c
Outdated
|
|
||
| /* clang-format off */ | ||
| data_t *data = data_make( | ||
| "model", "", DATA_STRING, "Aston-Martin-Smartire", |
There was a problem hiding this comment.
Only a single dash, and should be shorter. Since SmarTire is the manufacturer maybe SmarTire-AM?
And decoder file could be tpms_smartire.c perhaps?
There was a problem hiding this comment.
you're right, renamed everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #3067 about Aston Martin Smartire TPMS sensor.
Few flags not yet discovered but most of the key metrics (pressure & temp) are properly guessed.