rtl_433_mqtt_relay: Use id in topic even if there is a channel #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Note: commit message should be something like |
|
I find it funnny that you have to open a PR, get the number and then force-push with a new message, but that's easy... |
Previously, this example program appended /channel if present, and if not present and id was present, appended /id. Typically channel is from an A/B/C switch on the device or fixed for kind of device, and id is from a 16 bit or larger space, sometimes static, and sometimes random on powerup. Using only channel is bad if 1) one has more than one device, or more than 3 if A/B/C or 2) one's neighbor gets such a device. Because it is essentially impossible to rule out point 2, id should always be used.
|
You can edit the commit message when pressing "Squash and merge", it defaults to the PR title with the id added :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this example program appended /channel if present, and if not present and id was present, appended /id. Typically channel is from an A/B/C switch on the device or fixed for kind of device, and id is from a 16 bit or larger space, sometimes static, and sometimes random on powerup. Using only channel is bad if 1) one has more than one device, or more than 3 if A/B/C or 2) one's neighbor gets such a device. Because it is essentially impossible to rule out point 2, id should always be used.