Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splint, modified some files to pass checks #2639

Closed
wants to merge 1 commit into from
Closed

Add splint, modified some files to pass checks #2639

wants to merge 1 commit into from

Conversation

mdeweerd
Copy link
Contributor

This adds splint as a workflow.

  • do_splint.sh (with splint installed) with arguments will check only those files without disabling warnings.
    Without arguments it checks "all" files (a lot of files were excluded).
  • Except for a duplicate function warning, I disabled all messages and files that could not be parsed.
  • Files are excluded by grepping the list of 'c' files resulting from a find (in do_splint.sh). So to enable parsing for a file in the workflow, that has to be updated.

Most of the time parsing fails because variables are not defined at the start of a block.
I adjusted some files for that and in 'include/abuf.h' I added a '#ifndef S_SPLINT_S' to work around the elipsis limitation of splint.

@mdeweerd mdeweerd mentioned this pull request Sep 25, 2023
@mdeweerd mdeweerd closed this Sep 26, 2023
@mdeweerd mdeweerd deleted the add-splint branch September 26, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant