Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example hass typo fixes #2565

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Example hass typo fixes #2565

merged 1 commit into from
Jul 14, 2023

Conversation

DigiH
Copy link
Contributor

@DigiH DigiH commented Jul 14, 2023 •
edited
Loading

I think this is a typo/legacy definition in the hass example, as only ever rain_rate_mm_h is used in the actual decoders.

@DigiH DigiH mentioned this pull request Jul 14, 2023
Merged
3 tasks
@DigiH DigiH changed the title Example hass typo fix Example hass typo fixes Jul 14, 2023
@zuckschwerdt
Copy link
Collaborator

Good find about the rain_rate_mm_h. But the other two have conversions applied and are thus reported in mm not in.

@DigiH
Copy link
Contributor Author

DigiH commented Jul 14, 2023

True ;) reverted them back to mm and mm/h

@zuckschwerdt zuckschwerdt merged commit 37b804c into merbanan:master Jul 14, 2023
5 checks passed
@DigiH DigiH deleted the example branch July 14, 2023 16:18
andrewjw pushed a commit to andrewjw/rtl_433 that referenced this pull request Sep 29, 2023
@DigiH @andrewjw
Fix HASS script rain_rate_mm_h typo (merbanan#2565)
d84e082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DigiH @zuckschwerdt