WIP: Handle occlusion and the 'visible' key in ljsonv3 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a staging branch, which means a production build of this branch exists and can be launched. Click here to preview this PR.
This PR handles the 'visible' key that may be present in ljsonv3. The ljsonv3 spec can be found here: https://github.com/menpo/landmarker.io/wiki/LEP-0001:-LJSON-v3
Occlusion is included in saved ljson files and can be toggled for each landmark by pressing 'o' on the keyboard. Occluded landmarks appear as red on the template grid.
This PR is to be merged after the ljsonv3 PR: #136