Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA-832: Simplify test_preferred_versions #2247

Merged
merged 2 commits into from
Jan 30, 2025
Merged

QA-832: Simplify test_preferred_versions #2247

merged 2 commits into from
Jan 30, 2025

Conversation

lluiscampos
Copy link
Contributor

@lluiscampos lluiscampos commented Jan 28, 2025 •
edited
Loading

No description provided.

@mender-test-bot
Copy link

@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".

my commands and options

You can trigger a pipeline on multiple prs with:

  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can start a fast pipeline, disabling full integration tests with:

  • mentioning me and start pipeline --fast

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@lluiscampos
Copy link
Contributor Author

@mender-test-bot start pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-1645186834

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2247/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@lluiscampos lluiscampos force-pushed the QA-832-simplify-test-preferred branch from f5d1c84 to 462cd87 Compare January 29, 2025 06:55
@lluiscampos
test: Remove native variant of Mender client from `test_preferred_ver…
47b45fb 
…sions`

This recipe is only used for CI builds, where a regression will be
caught elsewhere.

Ticket: QA-832

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos
test: Remove unnecessary double testing in test_preferred_versions
9481938 
Since we are specifying the versions on `local.conf`, the "pn style" is
not relevant.

This simplification tentatively halves the execution time of the test.

Ticket: QA-832

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos lluiscampos force-pushed the QA-832-simplify-test-preferred branch from 462cd87 to 9481938 Compare January 29, 2025 06:57
@lluiscampos
Copy link
Contributor Author

@mender-test-bot start pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-1646098834

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2247/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

danielskinstad
danielskinstad approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@danielskinstad danielskinstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me :)

@lluiscampos lluiscampos merged commit d3a1b12 into mendersoftware:master Jan 30, 2025
14 checks passed
@lluiscampos lluiscampos deleted the QA-832-simplify-test-preferred branch January 30, 2025 12:44
This was referenced Jan 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielskinstad danielskinstad danielskinstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lluiscampos @mender-test-bot @danielskinstad