fix: fail deployment when it's aborted #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluiscampos
requested changes
Nov 7, 2024
vpodzime
reviewed
Nov 7, 2024
Changelog: Title Ticket: MEN-7693 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
danielskinstad
force-pushed
the
abort-deployment
branch
from
20e2f05
to
65f9994
Compare
|
Merging these commits will result in the following changelog entries: Changelogsmender-mcu (abort-deployment)New changes in mender-mcu since main: Bug Fixes
|
lluiscampos
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know if we wanted to fail on everything except
204, so I addedMENDER_ABORTED. If we can go to failure on everything except a204, then we could just check forMENDER_FAILI also added a check to reboot just in case you abort right after the check in install